From: René Scharfe <l.s.r@web.de>
Date: Sat, 4 Oct 2014 08:41:13 +0000 (+0200)
Subject: mailsplit: remove unnecessary unlink(2) call
X-Git-Tag: v2.2.0-rc0~50^2
X-Git-Url: http://git.bitbasher.net/?a=commitdiff_plain;h=db7879438f0a3d7607555cf166b42ed1083272b6;p=git.git

mailsplit: remove unnecessary unlink(2) call

The output file hasn't been created at this point, yet, so there is no
need to delete it when exiting early.

Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/mailsplit.c b/builtin/mailsplit.c
index 763cda098c..8e02ea109a 100644
--- a/builtin/mailsplit.c
+++ b/builtin/mailsplit.c
@@ -59,7 +59,6 @@ static int split_one(FILE *mbox, const char *name, int allow_bare)
 	int is_bare = !is_from_line(buf.buf, buf.len);
 
 	if (is_bare && !allow_bare) {
-		unlink(name);
 		fprintf(stderr, "corrupt mailbox\n");
 		exit(1);
 	}