From: Felipe Contreras Date: Tue, 21 May 2013 01:02:45 +0000 (-0500) Subject: transport-helper: barf when user tries old:new X-Git-Tag: v1.8.4-rc0~207^2~1 X-Git-Url: http://git.bitbasher.net/?a=commitdiff_plain;h=67c9c782dae17822266783f8b5e15d73e7c91c65;p=git.git transport-helper: barf when user tries old:new Otherwise with certain remote helpers (the ones that support 'export'), the users will be pushing to the wrong branch: git push topic:master Will push the topic branch, as if the user typed: git push topic Signed-off-by: Felipe Contreras Signed-off-by: Junio C Hamano --- diff --git a/transport-helper.c b/transport-helper.c index 522d79178e..a782a9bd71 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -813,9 +813,11 @@ static int push_refs_with_export(struct transport *transport, die("remote-helpers do not support ref deletion"); } - if (ref->peer_ref) + if (ref->peer_ref) { + if (strcmp(ref->peer_ref->name, ref->name)) + die("remote-helpers do not support old:new syntax"); string_list_append(&revlist_args, ref->peer_ref->name); - + } } if (get_exporter(transport, &exporter, &revlist_args))