From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 14 Oct 2015 22:33:07 +0000 (-0700)
Subject: mailinfo: remove a no-op call convert_to_utf8(it, "")
X-Git-Tag: v2.7.0-rc0~48^2~34
X-Git-Url: http://git.bitbasher.net/?a=commitdiff_plain;h=2a5ce7cf0da8c4d97dd58f5cbc6092b394648356;p=git.git

mailinfo: remove a no-op call convert_to_utf8(it, "")

The called function checks if the second parameter is either a NULL
or an empty string at the very beginning and returns without doing
anything.  Remove the useless call.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/mailinfo.c b/builtin/mailinfo.c
index 999a5250fb..5a4ed75a2d 100644
--- a/builtin/mailinfo.c
+++ b/builtin/mailinfo.c
@@ -612,11 +612,6 @@ static void decode_header(struct strbuf *it)
 {
 	if (decode_header_bq(it))
 		return;
-	/* otherwise "it" is a straight copy of the input.
-	 * This can be binary guck but there is no charset specified.
-	 */
-	if (metainfo_charset)
-		convert_to_utf8(it, "");
 }
 
 static void decode_transfer_encoding(struct strbuf *line)