ref_update_reject_duplicates(): use `size_t` rather than `int`
authorMichael Haggerty <mhagger@alum.mit.edu>
Mon, 22 May 2017 14:17:46 +0000 (16:17 +0200)
committerJunio C Hamano <gitster@pobox.com>
Tue, 23 May 2017 05:29:55 +0000 (14:29 +0900)
Eliminate a theoretical risk of integer overflow if the two types have
different sizes.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
refs.c

diff --git a/refs.c b/refs.c
index beb49fb..143936a 100644 (file)
--- a/refs.c
+++ b/refs.c
@@ -1705,7 +1705,7 @@ int create_symref(const char *ref_target, const char *refs_heads_master,
 int ref_update_reject_duplicates(struct string_list *refnames,
                                 struct strbuf *err)
 {
-       int i, n = refnames->nr;
+       size_t i, n = refnames->nr;
 
        assert(err);