branch: use non-gentle write_file for branch description
authorJeff King <peff@peff.net>
Fri, 8 Jul 2016 09:08:54 +0000 (05:08 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 8 Jul 2016 16:47:28 +0000 (09:47 -0700)
commit3d75bba28d8665ec43f1faffce38d5817c77ebe8
treea8b87326926d2ab316b83a77d35f6a521c76c33c
parent1dad879a7b7b41381cf4ccf471dcab06993a131b
branch: use non-gentle write_file for branch description

We use write_file_gently() to do this job currently.
However, if we see an error, we simply complain via
error_errno() and then end up exiting with an error code.

By switching to the non-gentle form, the function will die
for us, with a better error. It is more specific about which
syscall caused the error, and that mentions the
actual filename we're trying to write.

Our exit code for the error case does switch from "1" to
"128", but that's OK; it wasn't a meaningful documented code
(and in fact it was odd that it was a different exit code
than most other error conditions).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/branch.c